Add Path Title plugin

[jdeal]

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/jdeal/obsidian-path-title-plugin

Release Checklist

• I have tested the plugin on
  • Windows
  • macOS
  • Linux
  • Android (if applicable)
  • iOS (if applicable)
• My GitHub release contains all required files
  • main.js
  • manifest.json
  • styles.css (optional)
• GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
• The id in my manifest.json matches the id in the community-plugins.json file.
• My README.md describes the plugin's purpose and provides clear usage instructions.
• I have read the tips in https://github.com/obsidianmd/obsidian-releases/blob/master/plugin-review.md and have self-reviewed my plugin to avoid these common pitfalls.
• I have added a license in the LICENSE file.
• My project respects and is compatible with the original license of any code from other plugins that I'm using.
  I have given proper attribution to these other projects in my README.md.

[lishid]

https://github.com/jdeal/obsidian-path-title-plugin/blob/948fc84216ae1b016daeae44b893dafaa3c0ba3d/src/plugin.ts#L53
The rename event can sometimes be called many times consecutively (when renaming a folder with lots of subfolders) - you should debounce the setPaneTitles function.

https://github.com/jdeal/obsidian-path-title-plugin/blob/948fc84216ae1b016daeae44b893dafaa3c0ba3d/src/plugin.ts#L144
This should be reused - put it in a variable and reference it again.

I also suggest you detaching the element instead of just setting its display to none.

https://github.com/jdeal/obsidian-path-title-plugin/blob/948fc84216ae1b016daeae44b893dafaa3c0ba3d/src/plugin.ts#L166
Here you are not removing the elements you added (.path-title-plugin-path-title-container).

https://github.com/jdeal/obsidian-path-title-plugin/blob/948fc84216ae1b016daeae44b893dafaa3c0ba3d/src/plugin.ts#L61
I feel like the execution complexity here doesn't warrant the extra effort for memoizing path replacements - if you update paths on a reasonable debounce I recommend removing the memoization and just call the function for every file view.

[jdeal]

Hey @lishid, thanks for the suggestions! Sorry for the slow reply, but I made all those changes, which you can see in a comparison here. Let me know if there's anything else I should change.

[lishid]

https://github.com/jdeal/obsidian-path-title-plugin/blob/7be09b6d58de956bf02dc847521fbc78f953d08e/src/plugin.ts#L158
Possible crash here if find returns null.

[jdeal]

Thanks for another catch @lishid! Fixed in a subsequent build, along with another potential null I found. And thanks for merging anyway!