Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Setlist.fm Sync #4730

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add plugin: Setlist.fm Sync #4730

wants to merge 3 commits into from

Conversation

Fleker
Copy link
Contributor

@Fleker Fleker commented Nov 21, 2024

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/Fleker/setlist-for-obsidian

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Could not parse community-plugins.json, invalid JSON. Unexpected token ']', ..."idian"
},
]
" is not valid JSON


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@github-actions github-actions bot changed the title Add Setlist.fm to Obsidian plugins Add plugin: Setlist.fm Sync Nov 21, 2024
@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, assigning human for additional review.

@joethei
Copy link
Collaborator

joethei commented Nov 21, 2024

Remove the styles.css file from your release, since it's empty it's just unnecessary bloat that Obsidian would download.

"description": "Syncs your Setlist.fm attended concerts to Obsidian.",
Don't include "Obsidian" in your description.

This can help you keep track of movies you've seen as well as when you've seen them
Movies? I don't see anything on the setlist website that shows that this is possible.

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Nov 21, 2024
@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Nov 22, 2024
@Fleker
Copy link
Contributor Author

Fleker commented Nov 22, 2024

Thanks, I've resolved the issues you raised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants