-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import Textbundle files #677
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7e0ec15
Import Textbundle files
kepano 3450f97
Add guide to Import landing page
kepano 567b1f5
Minor formatting fix
kepano 76c86a0
Update textbundle import with limitations and troubleshooting
tgrosinger 1cd37aa
Merge branch 'master' into import-textbundle
sigrunixia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kepano and @tgrosinger What do you think of:
On MacOS devices, the textbundle import will import one textbundle file at a time. To process multiple textbundle files at once, you will need to compress all of the textbundle files into a single
.zip
file before importing with Importer.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we determine it happens on all Apple devices, we can adjust MacOS accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of saying it will import them one at a time, I would try to indicate that they will need to run the importer once for each file. They can't select more than one textbundle file at a time and have it just run through them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 A slight change then. I am not sure how
On MacOS devices, Importer will process only one textbundle file per import. To process multiple textbundle files at once, you will need to compress all of the textbundle files into a single .zip file before importing with Importer.
Alternatively....
On MacOS devices, Importer will process only one textbundle file per import. Multiple individual textbundle files will require individual import attempts.
To more efficiently process multiple textbundle files at once, you will need to compress all of the textbundle files into a single .zip file before importing with Importer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of "will process" can we say "can only select"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with that. :)