Bug: FuzzySuggestModal's onChooseItem does not fire on enter/return with modifier keys

[cryy22]

I want to open a file selected via FuzzySuggestModal in a new tab, new split, or new window according to the modifier keys held down while the selection occurs, mirroring the behavior of Quick Switcher. However, onChooseItem is not currently firing when any modifier keys are held down.

Steps to reproduce:

• extend FuzzySuggestModal and implement getItems and getItemText with dummy data
• for onChooseItem, console.log("hello")
• invoke your FuzzySuggestModal from Obsidian
• hold down any one or more modifier keys (tried with Shift, Meta, Ctrl and Alt/Option on macOS) while pressing enter/return
• observe no message in the console, and the modal is not dismissed

[cryy22]

I've reproduced the issue in a sample plugin here: https://github.com/cryy22/obsidian-FuzzySuggestModal-bug-demo

[lishid]

This is currently on purpose but the procedure to allow other keys is not yet well documented:

constructor(app: App) {
  super(app);
  // @ts-ignore
  this.scope.register([], 'Tab', (evt: KeyboardEvent) => {
    // @ts-ignore
    if (!evt.isComposing && this.suggestions.useSelectedItem(evt)) {
      return false;
    }
  });
}

[Zachatoo]

Looks like the internal APIs changed a bit, here's the solution that worked for me. Would love to see better support for this.

constructor(app: App) {
  super(app);
  this.scope.register([], 'Tab', (evt: KeyboardEvent) => {
    // @ts-ignore
    if (!evt.isComposing && this.chooser.useSelectedItem(evt)) {
      return false;
    }
  });
}