Remove JVM settings from docker compose

[mehdihasan]

• Remove JVM settings from the docker compose
• Update Readme to clarify usage of JVM settings

fixes #580

[Bert-R]

The change is good, in the sense that it reportedly solves the user issue.
However... I wonder whether we should go this way or take one more step: totally remove the -Xss option. Do we really have reason to 'make it normal' to tune down the stack memory?

I checked the default on my system through this command: java -XX:+PrintFlagsFinal -version | grep ThreadStackSize:

     intx CompilerThreadStackSize                  = 1024                                   {pd product} {default}
     intx ThreadStackSize                          = 1024                                   {pd product} {default}
     intx VMThreadStackSize                        = 1024                                   {pd product} {default}
openjdk version "17.0.9" 2023-10-17
OpenJDK Runtime Environment Temurin-17.0.9+9 (build 17.0.9+9)
OpenJDK 64-Bit Server VM Temurin-17.0.9+9 (build 17.0.9+9, mixed mode, sharing)

I said 'make it normal'. I can imagine that users in some specific circumstances want to tune down the stack memory, but in normal situations, I would favor leaving it to the VM, to prevent issues of the type we just saw.

@mehdihasan @davideicardi Makes sense?

[mehdihasan]

I agree.

It has come to my attention and you may have also encountered the following message:

OpenJDK 64-Bit Server VM warning: Options -Xverify:none and -noverify were deprecated in JDK 13 and will likely be removed in a future release.

I would like to propose two potential courses of action:

Proposal 1: I recommend considering the removal of the 'noverify' option.

Proposal 2: Additionally, I would like to suggest the evaluation of removing all JVM tuning options, as they primarily offer optimization for individual use cases. This approach would empower users to apply their own preferred options or limitations based on their specific requirements.

Your thoughts @Bert-R @davideicardi ?

[Bert-R]

Indeed. Let's move that environment variable to the README and shortly describe there how they can tweak the JVM settings.

Can you change your PR that way? Otherwise, I can make a PR on Tuesday.

[mehdihasan]

How about now? I tried to be as precise as possible in the README.

[davideicardi]

I agree to use the "default" settings whenever it is possible. The less customization of the JVM we have, the better it is for everyone.

Eventually, if we find some options to be useful in certain scenarios, we can add a specific documentation section explain when you should considering adding a specific paramenters.

@mehdihasan Just try to rename the PR title to something more specific. What about: "Remove default JVM settings from docker compose"?

[Bert-R]

Thanks!