Support mounting extra classes #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To enable this, the Spring Boot layout is changed from JAR to ZIP. This is similar to the JAR layout, but using PropertiesLauncher. The PropertiesLauncher allows extending the class path through the loader.path system property. Extended the README with an example.
davideicardi
approved these changes
May 2, 2023
| @@ -64,4 +64,4 @@ ARGS="--add-opens=java.base/sun.nio.ch=ALL-UNNAMED -Xss256K \ | |||
| $HEAP_ARGS \ | |||
| $JVM_OPTS" | |||
|
|
|||
| exec java $ARGS -jar /kafdrop*/kafdrop*jar ${CMD_ARGS} | |||
| exec java $ARGS -Dloader.path=/extra-classes -jar /kafdrop*/kafdrop*jar ${CMD_ARGS} | |||
There was a problem hiding this comment.
If the dir is not mounted is not a problem right?
I mean what happen if dir doesn't exist?
There was a problem hiding this comment.
That's not an issue (tested it). It just doesn't load extra classes.
|
Nice feature! 🙏 @Bert-R |
|
Tried running this with an AWS MSK test cluster I have, but no luck getting it connect. Confirmed that my built JAR works with a local kafka instance on localhost:9092, and confirmed that I can connect to my MSK broker with a kafka Scala binary. Here's what I tried: My Then I run |
|
You need more JARs than just the IAM one. If it still fails after adding all required JARs then please post the log of Kafdrop |
|
Hmmm, from my understanding only the IAM one is required (eg ixs to use the kafka standalone binary to connect only requires the IAM JAR). Here's the error: seems to be an issue connecting to the node (no errors w/ JARs): |
|
Looks like something is wrong in your configuration settings, due to which Kafdrop cannot find Kafka. |
andrewchoi5
approved these changes
May 31, 2024
|
@andrewchoi5 Have you tested this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable this, the Spring Boot layout is changed from JAR to ZIP. This is similar to the JAR layout, but using PropertiesLauncher. The PropertiesLauncher allows extending the class path through the loader.path system property. Extended the README with an example.