add keyFormat and format query params to the view message link for topics #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorkzijlstra
force-pushed
the
feature/default-format-on-topic-links
branch
from
c2233b6 to
d3e1306
Compare
davideicardi
approved these changes
Jan 28, 2022
|
Not sure what / how to test this. It's controller logic and I don't see any other tests for them. Also not familiar with the test framework yet so I'll have to have a look later. |
|
@jorkzijlstra ok for now I think it should be fine. Can you just confirm that this change doesn't have any effect if |
|
@davideicardi I can confirm that since that is also what we are actually running. It will just revert to the
|
fape
reviewed
Oct 4, 2022
| @@ -124,7 +124,7 @@ | |||
| <tbody> | |||
| <#list topic.partitions as p> | |||
| <tr> | |||
| <td><a href="<@spring.url '/topic/${topic.name}/messages?partition=${p.id}&offset=${p.firstOffset}&count=100'/>">${p.id}</a></td> | |||
| <td><a href="<@spring.url '/topic/${topic.name}/messages?partition=${p.id}&offset=${p.firstOffset}&count=100&keyFormat${keyFormat}=&format=${format}'/>">${p.id}</a></td> | |||
There was a problem hiding this comment.
I think that sould be keyFormat=${keyFormat}&format=${format}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the view message for topic did not have the keyFormat and format query params specified which causes the message to be de-serialized in the "DEFAULT" format instead of the message.format specified in the config.
Fix #239