Redo a lot of macro code #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phytolizer
added a commit
to Phytolizer/Obsidian
that referenced
this pull request
Aug 2, 2021
Merge pull request obsidian-level-maker#169 from Phytolizer/unstable
dashodanger
pushed a commit
that referenced
this pull request
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PACKEDATTR is gone, replaced by #pragma pack.
Please let me know if the new CMakeLists works for you, it works for me on Windows/Linux despite not using Clang on either. I say this because I noticed you guarded the clang-tidy behind using the Clang compiler.