Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add forwarding daemonset and trace support #300

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

obs-gh-alexlew
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Jan 15, 2025

The following chart updates are necessary:

diff --git a/charts/agent/Chart.yaml b/charts/agent/Chart.yaml
index 6715f67..6861772 100644
--- a/charts/agent/Chart.yaml
+++ b/charts/agent/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: agent
 description: Chart to install K8s collection stack based on Observe Agent
 type: application
-version: 0.37.0
+version: 0.38.0
 appVersion: "1.1.0"
 dependencies:
   - name: opentelemetry-collector

@obs-gh-alexlew obs-gh-alexlew force-pushed the alew/forwarding-daemonset branch 3 times, most recently from 44da8bb to 1d5d2d5 Compare January 21, 2025 20:55
@@ -491,6 +498,18 @@ node-logs-metrics:
tolerations: []

ports:
otlp:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to disable these to free up the host ports on each node. for some reason only the existing daemonset has these mapped as host ports, the rest do not even though we're not explicitly disabling them. https://github.com/open-telemetry/opentelemetry-helm-charts/blob/dbddf8420986a72c0cb389edbce4d8b151841937/charts/opentelemetry-collector/values.yaml#L269 the defaults set a hostport but maybe it doesn't apply to non-daemonsets?

@obs-gh-alexlew obs-gh-alexlew force-pushed the alew/forwarding-daemonset branch from 1d5d2d5 to aef79b9 Compare January 21, 2025 21:03
@obs-gh-alexlew obs-gh-alexlew merged commit 8d654ae into main Jan 23, 2025
11 checks passed
@obs-gh-alexlew obs-gh-alexlew deleted the alew/forwarding-daemonset branch January 23, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants