fix: Unify pull/watch events before observek8sattributes #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unification of events is currently defined in transform/object, which was moved after observek8sattributes due to the Secret redaction requirements. However, the observek8sattributes custom processor expects the data from pull/watch to be unified. The solution to this is to extract the unification logic into a different processor, which can be injected in the pipeline before observek8sattributes.
obs-gh-enricogiorio
requested review from
obs-gh-alexlew,
obs-gh-mattcotter and
xueweiz
xueweiz
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unification of events is currently defined in transform/object, which was moved after observek8sattributes due to the Secret redaction requirements.
However, the observek8sattributes custom processor expects the data from pull/watch to be unified.
The solution to this is to extract the unification logic into a different processor, which can be injected in the pipeline before observek8sattributes.