Skip to content

fix zero for negative domains #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 13, 2022
Merged

fix zero for negative domains #934

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a5566ea
fix zero for negative domains
mbostock Jun 11, 2022
cbf33a9
test negative domain with the zero option
Fil Jun 13, 2022
b52429a
Update test/plots/travelers-covid-drop.js
Fil Jun 13, 2022
cab1bd0
order options
Fil Jun 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/scales/quantitative.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,8 @@ export function ScaleQ(key, scale, channels, {
const [min, max] = extent(domain);
if ((min > 0) || (max < 0)) {
domain = slice(domain);
if (order(domain) < 0) domain[domain.length - 1] = 0;
else domain[0] = 0;
if (order(domain) !== Math.sign(min)) domain[domain.length - 1] = 0; // [2, 1] or [-2, -1]
else domain[0] = 0; // [1, 2] or [-1, -2]
}
}

Expand Down
Loading