boolean greys #694
Merged
boolean greys #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
force-pushed
the
mbostock/boolean-greys
branch
from
b4ee717 to
9236c44
Compare
|
Yes. Can we extend this to having systematically two greys when the domain is boolean, always associating false with the lighter grey and true with the darker one? Right now if everything is true or everything is false, we get the same output. (This is what I had in mind in #692 (comment)) |
|
Ah, whoops. I thought I did that, but then it got lost in the iterations… Let me think some more. |
mbostock
force-pushed
the
mbostock/boolean-greys
branch
from
9236c44 to
e9f82b1
Compare
|
Okay, take another look @Fil? 🙏 |
mbostock
force-pushed
the
mbostock/boolean-greys
branch
from
e9f82b1 to
00df37b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the defined values associated with an ordinal or categorical color scale are entirely boolean (true or false), construct a default range from the greys color scheme, assigning the light gray to false and the dark gray to true (rather than turbo or tableau10). In addition, make the n = 2 ordinal schemes higher contrast by favoring the extrema.
I considered having categorical color scales continue to use tableau10, restricting this behavior to ordinal color scales. This would require changing the logic in asOrdinalType to similarly check whether the associated defined values are boolean. I wasn’t sure if it was desirable to do this check twice. And I went back and forth over whether this should be an exhaustive check or a fast check (looking only at the first defined value). But I think it’s better to do an exhaustive check here since the the greys color scheme won’t work very well if there are many values.