Skip to content

promote boolean to constant #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2022
Merged

promote boolean to constant #692

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,14 @@ const TypedArray = Object.getPrototypeOf(Uint8Array);
const objectToString = Object.prototype.toString;

// This allows transforms to behave equivalently to channels.
export function valueof(data, value, type) {
const array = type === undefined ? Array : type;
return typeof value === "string" ? array.from(data, field(value))
: typeof value === "function" ? array.from(data, value)
: typeof value === "number" || value instanceof Date ? array.from(data, constant(value))
: value && typeof value.transform === "function" ? arrayify(value.transform(data), type)
: arrayify(value, type); // preserve undefined type
export function valueof(data, value, arrayType) {
const array = arrayType === undefined ? Array : arrayType;
const type = typeof value;
return type === "string" ? array.from(data, field(value))
: type === "function" ? array.from(data, value)
: type === "number" || value instanceof Date || type === "boolean" ? array.from(data, constant(value))
: value && typeof value.transform === "function" ? arrayify(value.transform(data), arrayType)
: arrayify(value, arrayType); // preserve undefined type
}

export const field = name => d => d[name];
Expand Down