Skip to content

Conversation

@mbostock
Copy link
Member

Fixes #659. No functional changes. To summarize:

  • A new options.js takes much of mark.js to normalize input options.
  • A new channels.js implements the mark sort option.
  • A new dimensions.js takes the dimensions-related code out of plot.js.
  • The basic transforms are combined into transforms/basic.js.
  • The remainder of mark.js and facet.js are folded into plot.js.

I looked at using the eslint-plugin-import to detect this at ESLint, but it adds a bunch of dependencies and is slow and doesn’t work out of the box with module aliases. So, we should just rely on Rollup’s warnings for now.

@mbostock mbostock requested a review from Fil January 16, 2022 06:17
@mbostock mbostock merged commit 75de2f8 into main Jan 16, 2022
@mbostock mbostock deleted the mbostock/acyclic-imports branch January 16, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using Plot with Webpack can lead to ReferenceErrors ("temporal dead zone") in production.

2 participants