don’t allow margins or insets to invert range #640
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #618. Fixes #616. This behavior is more consistent with how rects treat insets, e.g.,
plot/src/marks/rect.js
Lines 57 to 60 in 72b2adb
I’d slightly prefer using the midpoint here, something like:
But then I’d want rects to behave similarly, and I don’t think it’s really worth the trouble for such a rare thing. Mostly I just want to avoid the surprising (to me) behavior of the scale’s range getting inverted when the insets or margins are too big, and I think a collapsed range is a sufficient indication of a misconfiguration and we don’t need to do more.