Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rounded rect #2099

Merged
merged 22 commits into from
Jul 21, 2024
Merged

rounded rect #2099

merged 22 commits into from
Jul 21, 2024

Conversation

mbostock
Copy link
Member

@mbostock mbostock commented Jul 10, 2024 •
edited
Loading

TODO

  • rect
  • bar & cell
  • frame
  • r option
  • handle inverted orientations
  • handle corner radii that are too big
  • treat negative or invalid radii as zero
  • handle insets
  • handle missing channels
  • handle collapsed channels
  • handle projections
  • allow larger corners if asymmetric
  • consolidate code between rect, bar, and cell
  • optimize conditionals?
  • documentation
  • tests

Fixes #2054.

@mbostock
Copy link
Member Author

The implementation is now feature-complete and I’d welcome testing or feedback. I might try to optimize the conditionals, and add more documentation, before marking this as ready.

@mbostock mbostock marked this pull request as ready for review July 21, 2024 12:29
@mbostock mbostock requested a review from Fil July 21, 2024 12:29
@mbostock
Copy link
Member Author

I believe this is documented and ready for review. PTAL @Fil!

Fil
Fil approved these changes Jul 21, 2024
View reviewed changes
Copy link
Contributor

@Fil Fil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💊

docs/marks/rect.md Outdated Show resolved Hide resolved
@mbostock mbostock enabled auto-merge (squash) July 21, 2024 20:29
@mbostock mbostock merged commit 203bd4c into main Jul 21, 2024
1 check passed
@mbostock mbostock deleted the mbostock/rounded-rect branch July 21, 2024 20:31
@abdulrahman305 abdulrahman305 mentioned this pull request Aug 28, 2024
Merged
@FreeMason9224 FreeMason9224 mentioned this pull request Oct 4, 2024
Open
@NotDutchy NotDutchy mentioned this pull request Oct 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fil Fil Fil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rounded corners on rect, but only for some corners
2 participants
@mbostock @Fil