more GeoJSON awareness #2092
Merged
more GeoJSON awareness #2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1745. Fixes #1172.
First, this changes the
arrayifyinternal such that ifvaluesis a GeoJSON object, the corresponding array of features or geometries is returned. This makes GeoJSON objects usable as mark data for any mark, rather than being limited to the geo mark.Second, this changes the
fieldinternal such that if the requested field is undefined on the given objectd, it falls back tod.propertiesifdis a GeoJSON Feature object (d.type === "Feature"). This may have a slight performance overhead for such a core routine, but I expect the cost is negligible and I don’t think there is an alternative if we want GeoJSON to be more universally supported.