tip ignores literal colors #2091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fil
approved these changes
Jun 15, 2024
There was a problem hiding this comment.
The example in this PR would have displayed color: orange in the tips, which was not very informative.
There might be cases where you want the tip to display the actual color (for example if you are doing a visualization of colors) — this is possible by using the tip’s format option (e.g. tip: {format: {fill: true}}).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2090. Uses a new
channel.defaultScalefield to record what thechannel.scalewould have been, if it weren’t for the specific values provided. This allows the tip mark to detect when a channel would have been associated with the color scale, but isn’t, and hence contains only literal color values that should not be shown (at least by default) in the tip.