-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy initial value from svg to figure #2046
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems correct but I’m curious how the svg.value gets set erroneously in the first place, and what prevents it from subsequently getting set again in the wrong place? (I can investigate this myself by looking at the code, but if you’re willing it would be nice to summarize more of what the underlying cause is here.)
The pointer transform initializes svg.value: plot/src/interactions/pointer.js Line 182 in 00610bb
it dispatches here before we actually have a figure: plot/src/interactions/pointer.js Line 129 in 00610bb
Once the figure has replaced the svg, the value is dispatched correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
closes #2045