x and y reducers for group and hexbin #1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
mbostock
changed the title
mbostock
force-pushed
the
mbostock/group-reduce-xy
branch
2 times, most recently
from
22fd001 to
9672349
Compare
Fil
reviewed
Nov 6, 2023
Comment on lines
+71
to
+72
| // TODO scope | ||
| // TODO label |
There was a problem hiding this comment.
This made me think of how we would type the reduceIndex method for scope = "data" or "facet". Maybe something like the following, but it seems a bit messy:
reduceIndex(
index: number[],
values: undefined | S[],
valueOrExtent: any | {data: any[]},
maybeExtent: undefined | {data: any[]}
): T;
Fil
approved these changes
Nov 6, 2023
mbostock
force-pushed
the
mbostock/group-reduce-xy
branch
from
9672349 to
3f20fe1
Compare
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* x and y reducers for group * x and y reducers for hexbin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1530.