Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the denseInterval option for k must also reduce k1 and k2 if present #1828

Merged
merged 5 commits into from
Aug 24, 2023

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Aug 23, 2023

closes #1784

@Fil Fil requested a review from mbostock August 23, 2023 15:24
src/transforms/bin.js Outdated Show resolved Hide resolved
src/transforms/bin.js Outdated Show resolved Hide resolved
@mbostock mbostock enabled auto-merge (squash) August 24, 2023 01:02
@mbostock mbostock merged commit 1ff36a3 into main Aug 24, 2023
@mbostock mbostock deleted the fil/fix-area-interval branch August 24, 2023 01:04
chaichontat pushed a commit to chaichontat/plot that referenced this pull request Jan 14, 2024
…bservablehq#1828)

* the denseInterval option for k must also reduce k1 and k2 if present

closes observablehq#1784

* Update src/transforms/bin.js

* conditional reduce of k, too

* prettier

---------

Co-authored-by: Mike Bostock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The areaY mark’s interval option doesn’t work with y1 and y2
2 participants