fix non-faceted pointer #1713
Merged
fix non-faceted pointer #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
force-pushed
the
mbostock/non-faceted-pointer
branch
from
ccdf56d to
b3446ce
Compare
Fil
pushed a commit
that referenced
this pull request
Aug 21, 2023
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1677.
The code was confusing the plot being faceted vs. the current mark being faceted. If the plot is faceted, but the current mark is not faceted, we still need to populate the index.fx, index.fy, and index.fi fields so that the mark knows which facet is being rendered. Since the index is reused across facets, we create a defensive copy so that these fields aren’t mutated after the mark renders (e.g., in the case of an asynchronous render transform). We use index.subarray if the index is a typed array, which should be faster than create a copy using index.slice.