Auto: given bar, use cell over rect when no reducer #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
approved these changes
Jun 7, 2023
Fil
pushed a commit
that referenced
this pull request
Aug 21, 2023
* given bar, use cell over rect when no reducer * lint * test output
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* given bar, use cell over rect when no reducer * lint * test output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there's no reducer, the rects will have no extent, so we should treat numbers as ordinal. Fixes #1672. This lets us get to e.g. the Simpsons ratings heatmap:
This will never be chosen unless
mark: "bar"is passed, because ofisZeroReducer(xReduce) || isZeroReducer(yReduce) || colorReduce != null ? "bar"above.