fix facet channel sort with transform #1316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
force-pushed
the
mbostock/fix-transform-facet-channel-domain
branch
from
4ef3f7c to
92fee30
Compare
Fil
added a commit
that referenced
this pull request
Mar 6, 2023
Fil
approved these changes
Mar 6, 2023
There was a problem hiding this comment.
I've checked that it works well in conjunction with #1315.
Build: https://observablehq.com/@observablehq/plot-sort-1315-1316
mbostock
force-pushed
the
mbostock/fix-transform-facet-channel-domain
branch
from
43aaeb0 to
35922e6
Compare
mbostock
commented
May 8, 2023
| if (facets === undefined && data != null) facets = [range(data)]; | ||
| const originalFacets = facets; | ||
| if (this.transform != null) ({facets, data} = this.transform(data, facets)), (data = arrayify(data)); | ||
| if (facets !== undefined) facets.original = originalFacets; // needed up read facetChannels |
There was a problem hiding this comment.
“needed up read facetChannels” 🤔
There was a problem hiding this comment.
"needed to reindex the facet channel" (?)
or remove
There was a problem hiding this comment.
Ah ha. I think I meant “needed to read facetChannels”.
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* fix facet channel sort with transform * marginLeft—less minimalist, but more readable * rule y = 0 --------- Co-authored-by: Philippe Rivière <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #840.