combine prettier into main workflow #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
force-pushed
the
mbostock/unify-workflow
branch
from
e8770f0 to
a5f597c
Compare
mbostock
commented
Jan 16, 2023
| @@ -25,7 +25,8 @@ jobs: | |||
| - run: yarn --frozen-lockfile | |||
| - run: | | |||
| echo ::add-matcher::.github/eslint.json | |||
| yarn run eslint . --format=compact | |||
| yarn run eslint src test --format=compact | |||
There was a problem hiding this comment.
I think the eslint . works in CI because we haven’t generated any files yet (whereas it will fail locally with errors on generated files in build and types). So, this is just being more explicit about what we’re testing so that it’s not confusing when you try to run this command locally.
Fil
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to work. Example of prettier failure: https://github.com/observablehq/plot/actions/runs/3933377163