Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tickFormat type is missing third argument, domain? #1640

Open
winner106 opened this issue May 26, 2023 · 2 comments
Open

tickFormat type is missing third argument, domain? #1640

winner106 opened this issue May 26, 2023 · 2 comments
Labels
question Further information is needed types TypeScript declarations

Comments

@winner106
Copy link

tickFormat?: string | ((t: any, i: number) => any) | null;

should it be tickFormat?: string | ((t: any, i: number, D:any) => any) | null;
@mbostock mbostock added the question Further information is needed label May 26, 2023
@mbostock
Copy link
Member

Probably, but there are some cases (e.g. color legends) where it is not passed the full domain. Perhaps it should be?

@mbostock mbostock added the types TypeScript declarations label May 26, 2023
@mbostock mbostock changed the title tickFormat type error tickFormat type is missing third argument, domain? May 27, 2023
@mbostock mbostock mentioned this issue Jun 1, 2023
Merged
Fil added a commit that referenced this issue Jun 2, 2023
@Fil
normalize tickFormat's arguments
99d3a00 
closes #1640
@Fil Fil mentioned this issue Jun 2, 2023
Closed
@Fil
Copy link
Contributor

Fil commented Jun 2, 2023

I hope I've caught them all in #1669.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is needed types TypeScript declarations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

normalize tickFormat's arguments observablehq/plot
3 participants
@Fil @mbostock @winner106