more inputs #190
more inputs #190
Conversation
There was a problem hiding this comment.
Ideas for improvement of the color input:
Following the spec, a type=color input only accepts #rrggbb formatted values: no named colors, no 'rgb(…)' strings, no opacity, and of course no d3 colors.
I understand that we don't want to add d3-color as a dependency, but it would be a nice improvement in usability.
An alternative might be to reference this in the API documentation: something like "the value must be given in the #rrggbb hexadecimal format. For example: viewof color = Inputs.color({value: d3.rgb(defaultColor).formatHex()})"
Also, what would be the best way to make the output editable? Even if it's not by editing the text output, it would seem useful to be able to paste a color from the clipboard. In my tests the Chrome UI for this input has a text (sub-)input in which I can paste a hex color; Safari and Firefox use the same osx thing which is quite … complicated.
mbostock
force-pushed
the
mbostock/more-inputs
branch
from
0ba8fe6 to
79b91bc
Compare
| ${maybeLabel(label, input)}<div class=__ns__-input> | ||
| <div class=__ns__-input>${input}${output}</div> |
There was a problem hiding this comment.
It looks like there are two .__ns__-input wrapper divs here, while all the other inputs seem to use just one.
Adds email, tel, url, password, and color inputs. The color input is a little bit special because we want an output to accompany the input so that we can see the color value (similar to how a range input has an accompany number input). I suppose the output could be an editable text input that coordinates with the color input… but I’ll leave that as future work. E.g.,
Fixes #42.
Fixes #41.