use registry.npmjs.org #1697
Merged
use registry.npmjs.org #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
force-pushed
the
mbostock/npm-registry
branch
from
fbc5913
to
f885af8
Compare
mbostock
commented
Sep 30, 2024
| let promise = npmVersionRequests.get(href); | ||
| if (promise) return promise; // coalesce concurrent requests | ||
| promise = (async function () { | ||
| const input = formatNpmSpecifier({name, range}); | ||
| process.stdout.write(`npm:${input} ${faint("→")} `); | ||
| const response = await fetch(href); | ||
| const response = await fetch(href, {...(!disttag && {headers: {Accept: "application/vnd.npm.install-v1+json"}})}); |
There was a problem hiding this comment.
This is the “abbreviated” response described here:
https://github.com/npm/registry/blob/main/docs/responses/package-metadata.md
Fil
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches from data.jsdelivr.com (which is currently down) to registry.npmjs.org (which is the ground truth) to resolve npm package versions. It also seems to be quite a bit faster.