home config option #1689
Merged
home config option #1689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
force-pushed
the
mbostock/home
branch
from
8814304
to
e1c06ff
Compare
|
Nice. Is the plan to use |
|
I originally implemented a logo option but I decided to replace it with a home option instead (incorporating both title and what would have been logo). Did I accidentally leave some of that code in this PR? I’ll remove it when I polish and add docs etc. |
CobusT
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a home config option which allows overriding how the link to the home page appears in the sidebar. In particular, this allows our docs site to show the Observable logo in the top-left rather than in the fixed header. When the sidebar is shown (either because the page is wide enough to show it naturally, or because it was displayed manually), we hide the Observable logo in the header to avoid showing it twice.
When the sidebar is hidden, the Observable logo reappears in the header as today.
Probably need some tests and polish so marking as draft for now.