Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getModuleHash needs to consider data loaders #1662

Merged
merged 9 commits into from
Sep 17, 2024
Merged

Conversation

mbostock
Copy link
Member

@mbostock mbostock commented Sep 13, 2024

Fixes #1661.

@mbostock mbostock requested a review from Fil September 13, 2024 22:33
@mbostock

This comment was marked as resolved.

@mbostock mbostock marked this pull request as ready for review September 16, 2024 21:15
@mbostock mbostock enabled auto-merge (squash) September 16, 2024 21:20
@mbostock mbostock merged commit e467a6b into main Sep 17, 2024
4 checks passed
@mbostock mbostock deleted the mbostock/fix-module-hash branch September 17, 2024 09:59
Fil added a commit that referenced this pull request Sep 17, 2024
Fil added a commit that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reactive updates don’t work for modules that load data loaders
2 participants