_ignoreDefaultFontLinks boolean private config option #1595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
reviewed
Aug 22, 2024
Member
mbostock
left a comment
mbostock
left a comment
There was a problem hiding this comment.
This doesn’t actually feel simpler to me; it feels like the same complexity but less powerful. (And I also quibble with the name ignoreDefaultFontLinks which I would probably invert to includeDefaultFonts, but that’s easily fixed.) I’m going to make some small tweaks to the extraHead branch which I think is still the way to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems more reasonable than introducing a new extraHead option; it doesn't change the default font stack that loads Source Serif (née Source Serif Pro, now Source Serif 4) from Google Fonts.
supersedes #1589
supersedes #1592