Skip to content

npm:react-dom #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2024
Merged

npm:react-dom #1467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 0 additions & 52 deletions docs/lib/react.md
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion src/client/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ function reject(root, error) {
}

function displayJsx(root, value) {
return (root._root ??= import("npm:react-dom/client").then(({createRoot}) => {
return (root._root ??= import("npm:react-dom").then(({createRoot}) => {
const node = document.createElement("DIV");
return [node, createRoot(node)];
})).then(([node, client]) => {
Expand Down
4 changes: 2 additions & 2 deletions src/resolvers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,8 @@ export async function getResolvers(

// Add React for JSX blocks.
if (page.code.some((c) => c.mode === "jsx")) {
staticImports.add("npm:react-dom/client");
globalImports.add("npm:react-dom/client");
staticImports.add("npm:react-dom");
globalImports.add("npm:react-dom");
}

// Add transitive imports for built-in libraries.
Expand Down