Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod-enter to open in new tab #1404

Merged
merged 1 commit into from
May 29, 2024
Merged

mod-enter to open in new tab #1404

merged 1 commit into from
May 29, 2024

Conversation

mbostock
Copy link
Member

This allows the Mod-Enter keyboard shortcut to open search results in a new tab, making it much easier browse through the results (without needing to restore the search query as in #897 — though we could still do that) as long as you don’t mind having more than one tab open.

@mbostock mbostock requested a review from Fil May 29, 2024 23:41
Copy link
Contributor

@Fil Fil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this brings keyboard navigation on par with cmd-click, so 👍

(I still see the need for #897 ;-) )

@mbostock mbostock merged commit c7b7ef7 into main May 29, 2024
4 checks passed
@mbostock mbostock deleted the mbostock/mod-enter branch May 29, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants