add the file path to the hash #1373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fil
added a commit
that referenced
this pull request
Sep 17, 2024
Fil
added a commit
that referenced
this pull request
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding the file name to the hash, we ensure that two files called with differently cased path names can be built — instead of colliding.
closes #1367
supersedes #1369
We also need to clarify that the same site that builds on a case-insensitive system (darwin) might fail to build on a case-sensitive system (ubuntu), as the referenced files might not be found. This is apparently not something we can catch early—and not a new issue in any case.
(Note: still experimenting. I pushed the branch to use CI, but still not sure this is the right call.)