Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prql #1078

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

prql #1078

wants to merge 3 commits into from

Conversation

mbostock
Copy link
Member

@mbostock mbostock commented Mar 16, 2024

Fixes #1075.

Doesn’t work with interpolated expressions, e.g.,

from gaia
filter phot_g_mean_mag < ${min}
sort {phot_g_mean_mag}
take 10

I’m not sure how we’d implement that… we’d need some way to represent placeholder values (such as ?) that are appropriately substituted during the transformation. PRQL does appear to support parameters so we should be able to use that: https://prql-lang.org/book/reference/syntax/parameters.html.

I’m also not sure if we also want to support a prql tagged template literal, since that would mean loading npm:prql-js in the browser (importing it dynamically, presumably?).

@mbostock mbostock requested a review from Fil March 16, 2024 00:31
@srenatus
Copy link

Just so you're aware -- with the next release, importing prql-js might change? I've been pursuing prql in observable-framework myself here, and that change -- switching the browser build to ESM module, hasn't been part of a release yet AFAICT.

@mbostock
Copy link
Member Author

That’s great to hear @srenatus. An ESM distribution would be welcome.

This was referenced Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PRQL
2 participants