Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save search queries (plural) #1044

Closed
wants to merge 6 commits into from
Closed

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Mar 12, 2024

This tries and implement the suggestions in #897 (comment)

I don't find this very usable. To go from one search result to the next, this requires typing:

  • cmd-/ to focus the search input
  • arrowUp to reactivate the previous query
  • arrowRight or Enter to unselect the query in order to be allowed to arrowDown
  • arrowDown to select the next search result
  • Enter to follow the link.

Furthermore, there is a bit of confusion when you type something, then select it, then navigate up in the search query history. (I think I got it to work, but 😓).

Maybe something is lacking in the implementation.

@Fil Fil requested a review from mbostock March 12, 2024 12:43
@Fil
Copy link
Contributor Author

Fil commented Nov 11, 2024

I still prefer #897

@Fil Fil closed this Nov 11, 2024
@Fil Fil deleted the fil/save-search-queries-plural branch November 11, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant