Skip to content

Deduplicate imports after resolving in renderModule #1718

@Fil

Description

@Fil

this is not always deduplicated in exported modules:

import "../../_npm/[email protected]/_esm.js";
import "../../_npm/[email protected]/_esm.js";

Mike says:

it’s because we deduplicate before resolving rather than after. So here there are two global imports of D3: the chart.js module imports npm:d3, and Plot imports npm:d3@^7.9.0. These are two distinct specifiers prior to resolving, but they both resolve to npm:[email protected] after. We can fix this in renderModule.

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions