fix #1660; getWatchPath needs findModule

observablehq · Sep 13, 2024 · 8cb2877 · 8cb2877
1 parent 6845ea8
commit 8cb2877
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/src/loader.ts b/src/loader.ts
@@ -255,12 +255,8 @@ export class LoaderResolver {
     const exactPath = join(this.root, path);
     if (existsSync(exactPath)) return exactPath;
     if (exactPath.endsWith(".js")) {
-      const basePath = exactPath.slice(0, -".js".length);
-      for (const ext of [".ts", ".jsx", ".tsx"]) {
-        const extPath = basePath + ext;
-        if (existsSync(extPath)) return extPath;
-      }
-      return; // loaders aren’t supported for .js
+      const module = findModule(this.root, path);
+      return module && join(this.root, module.path);
     }
     const foundPath = this.find(path)?.path;
     if (foundPath) return join(this.root, foundPath);

diff --git a/test/loader-test.ts b/test/loader-test.ts
@@ -170,3 +170,10 @@ describe("LoaderResolver.get{Source,Output}Info(path)", () => {
     assert.deepStrictEqual(loaders.getOutputInfo("input/loader/not-cached.txt"), undefined);
   });
 });
+
+describe("LoaderResolver.getWatchPath(path)", () => {
+  it("returns the path to a parameterized module", async () => {
+    const loaders = new LoaderResolver({root: "test/input/params"});
+    assert.deepStrictEqual(loaders.getWatchPath("prefix-test.js"), "test/input/params/prefix-[file].js");
+  });
+});