Renaming GetGroupItemList to GetGroupSceneItemList #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had a type error with the "GetGroupItemList" request. After looking around, found out that it is "GetGroupSceneItemList" for v5 reference: https://docs.google.com/spreadsheets/d/1LfCZrbT8e7cSaKo_TuPDd-CJiptL7RSuo8iE63vMmMs/edit#gid=1402923009
|
types.ts is autogenerated from obs-websocket provided protocol.json on new releases of obs-websocket. This typo was fixed a week after 5.0.0 release @tt2468 is 5.0.1 gonna be released soon considering the version bump commit? (If it is then I'd just wait for that since I'd run the update script anyway) |
|
merging as code tagged as 5.0.1 (in a separate branch from master) didn't include the correction |
|
Ah sorry for not responding to this, I knew there was somewhere I got pinged with a question. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I had a type error with the "GetGroupItemList" request. After looking around, found out that it is "GetGroupSceneItemList" for v5
reference: https://docs.google.com/spreadsheets/d/1LfCZrbT8e7cSaKo_TuPDd-CJiptL7RSuo8iE63vMmMs/edit#gid=1402923009