Add Kazan.run function, deprecate Kazan.Client
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO:
|
obmarg
force-pushed
the
feature/deprecate-client
branch
from
f4f5773
to
48651c5
Compare
`Kazan` only really has one job - talking to kubernetes. It doesn't make much sense for the primary function for talking to kubernetes to be hidden inside `Kazan.Client` while the `Kazan` module goes unused. So, this commit deprecates `Kazan.Client` and presents the `Kazan.run` & `Kazan.run!` functions as alternatives.
obmarg
force-pushed
the
feature/deprecate-client
branch
from
48651c5
to
98397a0
Compare
Stops us getting our own deprecation warnings on compile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kazanonly really has one job - talking to kubernetes. It doesn't make muchsense for the primary function for talking to kubernetes to be hidden inside
Kazan.Clientwhile theKazanmodule goes unused.So, this commit deprecates
Kazan.Clientand presents theKazan.run&Kazan.run!functions as alternatives.