Adds a new icon set named Fontisto (http://fontisto.com) #977
Conversation
rfbezerra
force-pushed
the
add_fontisto_icon_set
branch
from
0871735
to
766d567
Compare
|
@rfbezerra this is a great PR but you're also doing many other things. Could you please extract the version bumping to a separate PR (that can fix and have a positive impact over existing issues: #993, #972 ) |
|
Oh, my bad. |
|
You have included old commits somehow, they have incorrect hashes and will mess with existing commits. Could you fix them as well? 🙂 |
rfbezerra
force-pushed
the
add_fontisto_icon_set
branch
from
766d567
to
8dd960b
Compare
|
I don't know what happened before, but I think this is ok now. |
|
Indeed, this font is really nice! The code looks fine and there is a build script as well 👍 Only thing is, could you add it to the directory and IconExplorer project as well? 🙂 |
|
@rfbezerra since I don't have push access to your fork, I've cloned it and did the work. Here's the diff that you can apply:
Please do let me know if you need any help with this. Thanks! |
|
I updated sources. |
|
@rfbezerra I don't know about the My workflow on doing is |
| @@ -158,7 +160,7 @@ class App extends PureComponent { | |||
| let familyName = family; | |||
|
|
|||
| if (family === 'FontAwesome5') { | |||
| if (FontAwesome5Meta['solid'].indexOf(name) === -1) | |||
| if (FontAwesome5Meta.solid.indexOf(name) === -1) | |||
|
Only thing left that I can find is that the font is not added to the IconExplorer ios project, I'd do it myself but I am currently not near a computer 🙂 Maybe linking the app should be enough but don't take my word for it. |
|
I test only in Android, my bad. |
|
🥳🥳 LGTM |
|
Thank you both 🙂 |
|
🤗 🍾 🎉 |
Recently I found a good icon-set named Fontisto
This PR adds it to the react-native-vector-icons icon sets