Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Windows instructions #1685

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

DylanAkp
Copy link

Updated Windows instructions as they were missing
Tested and working with react-native^0.76.5, react-native-windows^0.76.0 and react-native-vector-icons^10.2.0

@johnf
Copy link
Collaborator

johnf commented Dec 15, 2024

@DylanAkp Thanks this is great!

I have a quick question (since I want to try automating this with a script the same way we do for macOS): Is there a config file or something that changes when you add the assets in Visual Studio?

If you could send a diff that would be helpful.

@DylanAkp
Copy link
Author

DylanAkp commented Dec 16, 2024

Hello @johnf , it seems that the affected files are :

windows/<project_name>/<project_name>.vcxproj :
<Font Include="Assets\FontAwesome.ttf" />

and windows/<project_name>/<project_name>.vcxproj.filters

<Font Include="Assets\FontAwesome6_Brands.ttf">
    <Filter>Assets</Filter>
</Font>

Keep in mind that I use the default old/uwp-cpp-app template and a few others are available

@DylanAkp
Copy link
Author

Here is a diff after installing and using react-native-vector icons
Just uncheck/ignore all .tsx changes and you should be able to see everything you need

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants