Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crashes the app, as IOS has deprecated UIGraphicsBeginImageContextWithOptions from IOS 17. #1576

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Crashes the app, as IOS has deprecated UIGraphicsBeginImageContextWithOptions from IOS 17. #1576

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0378063
deprecated UIGraphicsBeginImageContextWithOptions patch.
CarmineRumma Dec 7, 2023
e37a5f0
Merge branch 'oblador:master' into closes#1575
CarmineRumma May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions RNVectorIconsManager/RNVectorIconsManager.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,15 +62,15 @@ - (BOOL)createAndSaveGlyphImage:(NSString *)glyph withFont:(UIFont *)font
// No cached icon exists, we need to create it and persist to disk

NSAttributedString *attributedString = [[NSAttributedString alloc] initWithString:glyph attributes:@{NSFontAttributeName: font, NSForegroundColorAttributeName: color}];

CGSize iconSize = [attributedString size];
UIGraphicsBeginImageContextWithOptions(iconSize, NO, 0.0);
[attributedString drawAtPoint:CGPointMake(0, 0)];
UIImage* newImage = [image imageWithRenderingMode: UIImageRenderingModeAlwaysTemplate];

UIImage *iconImage = UIGraphicsGetImageFromCurrentImageContext();
UIGraphicsEndImageContext();
UIGraphicsImageRenderer *renderer = [[UIGraphicsImageRenderer alloc] initWithSize:iconSize];
newImage = [renderer imageWithActions:^(UIGraphicsImageRendererContext * _Nonnull rendererContext) {
[attributedString drawAtPoint:CGPointMake(0, 0)];
}];

NSData *imageData = UIImagePNGRepresentation(iconImage);
NSData *imageData = UIImagePNGRepresentation(newImage);
return [imageData writeToFile:filePath atomically:YES];
}

Expand Down