Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(#3199): combine deps and resolve + fixed phi converting + removing mark #3998

Merged

Conversation

maxonfjvipon
Copy link
Member

Closes: #3199

@github-actions github-actions bot added the core label Mar 12, 2025
Copy link

github-actions bot commented Mar 12, 2025

🚀 Performance Analysis

Test Base Score PR Score Change % Change Unit Mode
benchmarks.XmirBench.xmirToEO 162.118 150.019 -12.099 -7.46% ms/op Average Time
benchmarks.XmirBench.xmirToPhi 155.838 144.470 -11.368 -7.29% ms/op Average Time
benchmarks.XmirBench.xmirToSaltyPhi 154.320 155.713 1.392 0.90% ms/op Average Time

✅ Performance gain: benchmarks.XmirBench.xmirToEO is faster by 12.099 ms/op (7.46%)
✅ Performance gain: benchmarks.XmirBench.xmirToPhi is faster by 11.368 ms/op (7.29%)
⚠️ Performance loss: benchmarks.XmirBench.xmirToSaltyPhi is slower by 1.392 ms/op (0.90%)

@maxonfjvipon
Copy link
Member Author

@yegor256 please check

@yegor256 yegor256 added this pull request to the merge queue Mar 13, 2025
@yegor256
Copy link
Member

@maxonfjvipon thanks!

Merged via the queue into objectionary:master with commit dd06689 Mar 13, 2025
25 checks passed
@0crat
Copy link

0crat commented Mar 20, 2025

@maxonfjvipon Great work on your contribution! 🌟 You've earned +4 points for this submission. While we noticed a high number of hits-of-code (1531) and few comments (3), we appreciate your effort. Your running balance is now +8. Keep the contributions coming, and remember to focus on quality in your future submissions. Looking forward to your next contribution!

@0crat
Copy link

0crat commented Mar 20, 2025

@yegor256 Hey there! 👋 Great job on the review! You've snagged +9 points for your effort. Here's the breakdown: +4 base points, +15 for reviewing a whopping 1531 hits-of-code (impressive!), but we had to deduct 10 points because there were only 3 comments. Remember, more comments can boost your score next time! Your current balance stands at -596. Keep up the good work and aim for those bonus points! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ResolveMojo should not be part of assemble cycle
3 participants