Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

less references to \rho #3482

Merged
merged 3 commits into from
Nov 10, 2024
Merged

less references to \rho #3482

merged 3 commits into from
Nov 10, 2024

Conversation

yegor256
Copy link
Member

@yegor256 yegor256 commented Nov 10, 2024

see #3481

removed a bit of redundant ^.


PR-Codex overview

This PR focuses on removing the use of the ^ operator in various eo files, which indicates accessing the parent scope. The changes streamline code by directly referencing the properties and methods without the need for the parent context.

Detailed summary

  • In while.eo, removed ^ from body and condition references.
  • In tuple.eo, removed ^ from head.length and index comparisons.
  • In i16.eo, removed ^ from multiple comparisons and arithmetic operations (lt, lte, gt, gte, times, plus, minus, div).
  • Adjusted error handling message to remove ^ in the error message formatting.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@yegor256
Copy link
Member Author

@maxonfjvipon what do you think? Looks like we overuse the ^. prefix. It can be omitted in many situations (but not all!)

Copy link
Member

@maxonfjvipon maxonfjvipon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yegor256 yes, in most cases it can be injected automatically

@yegor256 yegor256 merged commit 91458c7 into master Nov 10, 2024
20 checks passed
@yegor256 yegor256 deleted the 3481 branch November 10, 2024 15:38
@0crat
Copy link

0crat commented Nov 24, 2024

@yegor256 Hey there! 👋 Thanks for your contribution! You've earned +4 points this time. Here's the breakdown: +4 base points, -4 because there were only a few comments (we like to see at least 6!), and +4 to keep you motivated. Remember, more hits-of-code and active code reviews can boost your points next time. Keep the contributions coming! Your current balance stands at -46. Let's see if we can bump that up! 💪

@0crat
Copy link

0crat commented Nov 24, 2024

@maxonfjvipon Great job on the review! 🌟 You've earned +4 points: +4 base, -10 for minimal comments, but +10 bonus to recognize your effort. Your current balance is +16. Keep up the good work and aim for more detailed feedback next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants