Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHI/UNPHI Removes All unlint And version Metas #3812

Closed
volodya-lombrozo opened this issue Jan 14, 2025 · 6 comments · Fixed by #3816
Closed

PHI/UNPHI Removes All unlint And version Metas #3812

volodya-lombrozo opened this issue Jan 14, 2025 · 6 comments · Fixed by #3816

Comments

@volodya-lombrozo
Copy link
Member

volodya-lombrozo commented Jan 14, 2025 •
edited
Loading

I have XMIR file with the following metas:

<metas>
    <meta>
        <head>package</head>
        <tail>j$org.j$eolang.j$hone</tail>
        <part>j$org.j$eolang.j$hone</part>
    </meta>
    <meta>
        <head>unlint</head>
        <tail>mandatory-package</tail>
    </meta>
    <meta>
        <head>version</head>
        <tail>0.1.0-SNAPSHOT</tail>
    </meta>
</metas>

Then I do the following:

  1. Convert this XMIR into PHI (phi)
  2. Convert PHI back to XMIR (unphi)
  3. Unroll PHI modifications (unroll from jeo-maven-version)

After all of there thransformations I get the XMIR without unlint and version metas:

<metas>
    <meta line="1">
        <head>package</head>
        <tail>j$org.j$eolang.j$hone</tail>
        <part>j$org.j$eolang.j$hone</part>
    </meta>
</metas>

This causes some errors in following pipelines. Please, keep all the metas in phi/unphi transformations up to the end.
@volodya-lombrozo
Copy link
Member Author

volodya-lombrozo commented Jan 14, 2025 •
edited
Loading

XMIR and PHI files:
App.xmir.disassemble.txt
App.phi.txt
App.xmir.unphi.txt
App.xmir.unroll.txt

@volodya-lombrozo volodya-lombrozo mentioned this issue Jan 14, 2025
Merged
@volodya-lombrozo
Copy link
Member Author

Blocks objectionary/jeo-maven-plugin#962

@volodya-lombrozo
Copy link
Member Author

@maxonfjvipon Could you have a look, please?

@volodya-lombrozo volodya-lombrozo mentioned this issue Jan 14, 2025
Closed
@maxonfjvipon
Copy link
Member

@volodya-lombrozo I think it's impossible since PHI notation does not support metas

@maxonfjvipon
Copy link
Member

@yegor256 any ideas?

@yegor256
Copy link
Member

yegor256 commented Jan 14, 2025 •
edited
Loading

@volodya-lombrozo indeed, there is no simple way to do this (and I'm sure we have to, since this information is EO-related, not model related). Maybe you can inject +unlint and +version into the XMIR when you get it back from phi-to-xmir mojo? Otherwise, just skip the linting step in production, it's a redundancy, I believe.

volodya-lombrozo added a commit to volodya-lombrozo/eo that referenced this issue Jan 15, 2025
@volodya-lombrozo
feat(objectionary#3812): fix minor grammar mistakes
3ed8db9
volodya-lombrozo added a commit to volodya-lombrozo/eo that referenced this issue Jan 15, 2025
@volodya-lombrozo
feat(objectionary#3812): add docs about possible loss of information
d17b87e
@volodya-lombrozo volodya-lombrozo mentioned this issue Jan 15, 2025
Merged
volodya-lombrozo added a commit to volodya-lombrozo/eo that referenced this issue Jan 15, 2025
@volodya-lombrozo
feat(objectionary#3812): remove trailing spaces
7a08c51
yegor256 added a commit that referenced this issue Jan 15, 2025
@yegor256
Merge pull request #3816 from volodya-lombrozo/3812_phi_unphi_docs
6e5f99d 
 feat(#3812): Extend Docs About 'PHI/UNPHI' Issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#3812): Extend Docs About 'PHI/UNPHI' Issues volodya-lombrozo/eo
3 participants
@yegor256 @maxonfjvipon @volodya-lombrozo