updating const to let #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was causing react-native 0.56 to crash. Had to apply this patch in order to make it work. |
|
@ahmedu007 could you please update your commit to include the change from @obipawan I can confirm this fix works on [email protected], would you mind merging it and publishing new version to npm? |
|
@obipawan Can you please merge this in? Confirmed this is a RN 0.56 issue and that simple one line fixes it.
|
|
Apologies folks. I'll be pushing out an update in some time. |
|
Available on v0.0.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using this lib with react-native-web. Its not letting me compile since the const is being redefined in the function. Updating the
constto aletto solve the issue and fix the convention.