-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow adapters to process types that deref to their vertex type. #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit tests pass.
obi1kenobi
added
C-enhancement
Category: raise the bar on expectations
L-rust
Language: affects use cases in the Rust programming language
R-breaking-change
Release: implementing or merging this will introduce a breaking change.
R-relnotes
Release: document this in the release notes of the next release
labels
Oct 7, 2023
obi1kenobi
commented
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-enhancement
Category: raise the bar on expectations
L-rust
Language: affects use cases in the Rust programming language
R-breaking-change
Release: implementing or merging this will introduce a breaking change.
R-relnotes
Release: document this in the release notes of the next release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, adapter implementations were unnecessarily strict: they required that the
DataContext
contain specifically theirVertex
type. They would refuse to work in a situation where theDataContext
contained a type that within it contained aVertex
i.e. could dereference to aVertex
upon request. That made it harder than necessary to expose adapters across programming languages, or use them as building blocks that can combine their functionality.This PR changes the
Adapter
trait to allow anyDataContext<V>
representation, so long as thatV
type implementsAsVertex<Self::Vertex>
and has an appropriate lifetime for the adapter. When the adapter needs to look up theactive_vertex()
and get anOption<Self::Vertex>
back, it can do so via theAsVertex
trait which handles the conversion.AsVertex
has a blanket impl for allDebug + Clone
(i.e. validAdapter::Vertex
) types, so implementations should be able to upgrade to the new API by just changing theAdapter
fn signatures and without implementation changes.