feat: add trait_associated_type_default_removed lint #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
obi1kenobi
reviewed
Aug 27, 2024
There was a problem hiding this comment.
You're looking at the right thing, the feature just needed to be explicitly enabled in the test crates' source and our test infra will take it from there.
cc @PedroTurik this might be of interest to you too, since you've claimed the other lint that relies on associated type defaults.
mrnossiom
force-pushed
the
add-trait-associated-type-default-removed
branch
from
82e8930
to
7e587bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lint for "non-sealed trait removed the default value for an associated type"
See #870
It seems like "associated type defaults" are a nightly feature (see tracking issue rust-lang/rust#29661). Does
cargo-semver-checkssupport nightly features. Am I just wrong on what feature this lint should test?