Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove script usage of globstar, improving compatibility #683

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

jw013
Copy link
Contributor

@jw013 jw013 commented Mar 6, 2024

More enhancements for #680. This removes the requirement for v4+ of bash.

Copy link
Owner

@obi1kenobi obi1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, TIL about $PPID. Amazing job! 🚀

@obi1kenobi obi1kenobi merged commit 822d619 into obi1kenobi:main Mar 6, 2024
35 checks passed
@jw013 jw013 deleted the bash-compat branch March 9, 2024 02:16
@qstommyshu qstommyshu mentioned this pull request Mar 9, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants